Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: log route update id #3112

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

AlexanderYastrebov
Copy link
Member

Add and log route update counter to observe delay between receiving and applying routes.

@AlexanderYastrebov AlexanderYastrebov added the minor no risk changes, for example new filters label Jun 17, 2024
Add and log route update counter to observe delay between receiving and
applying routes.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@RomanZavodskikh
Copy link
Member

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 47c3db1 into master Jun 17, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the routing/log-update-id branch June 17, 2024 14:31
AlexanderYastrebov added a commit that referenced this pull request Jun 18, 2024
Increment update id only on update receival instead of
each loop cycle which results in odd update id values due to second select case branch.

Follow up on #3112

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Jun 18, 2024
Increment update id only on update receival instead of
each loop cycle which results in odd update id values due to second select case branch.

Follow up on #3112

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
MustafaSaber referenced this pull request in zalando-incubator/kubernetes-on-aws Jun 20, 2024
* \[docs: cleanup deprecated -lb-healthcheck-interval flag\]\(https://github.com/zalando/skipper/pull/3099\)
* \[build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz \]\(https://github.com/zalando/skipper/pull/3105\)
* \[build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0\]\(\zalando/skipper#3100)
* \[build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0\]\(https://github.com/zalando/skipper/pull/3104\)
* \[build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0\]\(https://github.com/zalando/skipper/pull/3102\)
* \[build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0\]\(https://github.com/zalando/skipper/pull/3106\)
* \[build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61\]\(https://github.com/zalando/skipper/pull/3109\)
* \[build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3\]\(https://github.com/zalando/skipper/pull/3110\)
* \[build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2\]\(https://github.com/zalando/skipper/pull/3108\)
* \[routing: log route update id\]\(https://github.com/zalando/skipper/pull/3112\)
* \[build(deps): bump actions/checkout from 4.1.6 to 4.1.7\]\(https://github.com/zalando/skipper/pull/3107\)
* \[routing: measure route update latency\]\(https://github.com/zalando/skipper/pull/3113\)
* \[doc: mention DCO and what to do in your commit\]\(https://github.com/zalando/skipper/pull/3114\)
* \[routing: refactor update id logging\]\(https://github.com/zalando/skipper/pull/3116\)
* \[OPA: Add response status to control plane traces\]\(https://github.com/zalando/skipper/pull/3118\)
* \[routing: measure CreateFilter latency\]\(https://github.com/zalando/skipper/pull/3115\)

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
Add and log route update counter to observe delay between receiving and
applying routes.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
Increment update id only on update receival instead of
each loop cycle which results in odd update id values due to second select case branch.

Follow up on zalando#3112

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants